[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b20bba75-e646-4c16-a4aa-7085291cfb1f@kernel.org>
Date: Mon, 16 Oct 2023 13:56:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Sandor Yu <Sandor.yu@....com>, dmitry.baryshkov@...aro.org,
andrzej.hajda@...el.com, neil.armstrong@...aro.org,
Laurent.pinchart@...asonboard.com, jonas@...boo.se,
jernej.skrabec@...il.com, airlied@...il.com, daniel@...ll.ch,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, festevam@...il.com,
vkoul@...nel.org, dri-devel@...ts.freedesktop.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Cc: kernel@...gutronix.de, linux-imx@....com, oliver.brown@....com,
alexander.stein@...tq-group.com, sam@...nborg.org
Subject: Re: [PATCH v10 4/7] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver
On 13/10/2023 05:24, Sandor Yu wrote:
> Add a new DRM DisplayPort and HDMI bridge driver for Candence MHDP8501
> used in i.MX8MQ SOC. MHDP8501 could support HDMI or DisplayPort
> standards according embedded Firmware running in the uCPU.
...
> +
> +static struct platform_driver cdns_mhdp8501_driver = {
> + .probe = cdns_mhdp8501_probe,
> + .remove = cdns_mhdp8501_remove,
> + .driver = {
> + .name = "cdns-mhdp8501",
> + .of_match_table = cdns_mhdp8501_dt_ids,
> + },
> +};
> +
> +module_platform_driver(cdns_mhdp8501_driver);
> +
> +MODULE_AUTHOR("Sandor Yu <sandor.yu@....com>");
> +MODULE_DESCRIPTION("Cadence MHDP8501 bridge driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:cdns-mhdp8501");
You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong.
This applies everywhere, to all your patches.
Best regards,
Krzysztof
Powered by blists - more mailing lists