linux-kernel - Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 16 Oct 2023 14:32:25 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Florian Eckert <fe@....tdt.de>, Eckert.Florian@...glemail.com,
        gregkh@...uxfoundation.org, pavel@....cz, lee@...nel.org,
        kabel@...nel.org, u.kleine-koenig@...gutronix.de
Cc:     linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-leds@...r.kernel.org
Subject: Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by
 replacing tabs with spaces.

On 16. 10. 23, 9:13, Florian Eckert wrote:
> Tabs were used in the function description, to make this look more
> uniform, the tabs were replaced by spaces where necessary.
> 
> Signed-off-by: Florian Eckert <fe@....tdt.de>

Reviewed-by: Jiri Slaby <jirislaby@...nel.org>


LGTM (spihnx prefers spaces), except:

> @@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver *driver)
>   EXPORT_SYMBOL(tty_register_driver);
>   
>   /**
> - * tty_unregister_driver -- unregister a tty driver
> + * tty_unregister_driver - unregister a tty driver

you should have noted you changed ndashes to dashes too. (As only the 
latter is supported by sphinx.)

thanks,
-- 
js
suse labs