[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <8a1c19dc-0a4f-4079-b2df-704ae647b1f8@kernel.org>
Date: Mon, 16 Oct 2023 14:42:16 +0200
From: Daniel Bristot de Oliveira <bristot@...nel.org>
To: Petr Mladek <pmladek@...e.com>,
Alessandro Carminati <alessandro.carminati@...il.com>
Cc: Kris Van Hees <kris.van.hees@...cle.com>,
Masami Hiramatsu <mhiramat@...nel.org>,
Steven Rostedt <rostedt@...dmis.org>,
Josh Poimboeuf <jpoimboe@...nel.org>,
Masahiro Yamada <masahiroy@...nel.org>,
Luis Chamberlain <mcgrof@...nel.org>,
Nathan Chancellor <nathan@...nel.org>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Nicolas Schier <nicolas@...sle.eu>,
Alexander Lobakin <aleksander.lobakin@...el.com>,
Nick Alcock <nick.alcock@...cle.com>,
Eugene Loh <eugene.loh@...cle.com>,
Francis Laniel <flaniel@...ux.microsoft.com>,
Viktor Malik <vmalik@...hat.com>, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH v5] scripts/link-vmlinux.sh: Add alias to duplicate
symbols for kallsyms
>> In any case, as you've pointed out, duplicates can arise from names in code
>> that is not intended to be a module.
>> Therefore, relying solely on the module name would not fully address the
>> problem you initially aimed to solve.
>
> From my POV:
>
> The source path and the line number is enough to distinguish duplicate
> symbols even in modules.
>
> The added module name would just add extra complexity into the kernel
> and tools parsing and using the alias. The tracing tools would need to
> handle the source path and line number anyway for symbols duplicated
> within same module/vmlinux.
>
> Adding module name for builtin modules might be misleading. It won't
> be clear which symbols are in vmlinux binary and which are in
> real modules.
+1
-- Daniel
Powered by blists - more mailing lists