[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231016134720.GA2650973-robh@kernel.org>
Date: Mon, 16 Oct 2023 08:47:20 -0500
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Sebastian Fricke <sebastian.fricke@...labora.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
NXP Linux Team <linux-imx@....com>,
Conor Dooley <conor+dt@...nel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Jackson Lee <jackson.lee@...psnmedia.com>,
Hans Verkuil <hverkuil@...all.nl>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Shawn Guo <shawnguo@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Nas Chung <nas.chung@...psnmedia.com>,
Fabio Estevam <festevam@...il.com>,
linux-media@...r.kernel.org, Tomasz Figa <tfiga@...omium.org>,
linux-kernel@...r.kernel.org,
Nicolas Dufresne <nicolas.dufresne@...labora.com>,
kernel@...labora.com, Robert Beckett <bob.beckett@...labora.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Darren Etheridge <detheridge@...com>
Subject: Re: [PATCH v13 6/8] media: dt-bindings: wave5: add Chips&Media 521c
codec IP support
On Thu, Oct 12, 2023 at 03:24:12PM +0200, Krzysztof Kozlowski wrote:
> On 12/10/2023 13:01, Sebastian Fricke wrote:
> > From: Robert Beckett <bob.beckett@...labora.com>
> >
> > Add bindings for the chips&media wave5 codec driver
> >
> > Signed-off-by: Robert Beckett <bob.beckett@...labora.com>
> > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> > Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>
> > ---
> > .../devicetree/bindings/media/cnm,wave5.yaml | 60 ++++++++++++++++++++++
> > 1 file changed, 60 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/cnm,wave5.yaml b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> > new file mode 100644
> > index 000000000000..b31d34aec05b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/cnm,wave5.yaml
> > @@ -0,0 +1,60 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/cnm,wave5.yaml#
>
> Filename matching compatible, so: cnm,cm521c-vpu.yaml
>
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Chips&Media Wave 5 Series multi-standard codec IP
> > +
> > +maintainers:
> > + - Nas Chung <nas.chung@...psnmedia.com>
> > + - Jackson Lee <jackson.lee@...psnmedia.com>
> > +
> > +description:
> > + The Chips&Media WAVE codec IP is a multi format video encoder/decoder
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - cnm,cm521c-vpu
>
> Can this device be anything else? Why VPU suffix?
It needs an SoC specific compatible (TI something...) as well (or
instead). Unless there's a public spec with details on how many
clocks, resets, interrupts, etc. there are.
Rob
Powered by blists - more mailing lists