linux-kernel - Re: [PATCH net-next v4 4/9] net: dsa: microchip: ksz9477: add Wake on LAN support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <18c20ed3-c117-4124-af3c-33df562b7f02@lunn.ch>
Date:   Mon, 16 Oct 2023 16:59:24 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        Arun Ramadoss <arun.ramadoss@...rochip.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com,
        "Russell King (Oracle)" <linux@...linux.org.uk>,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v4 4/9] net: dsa: microchip: ksz9477: add Wake
 on LAN support

> +int ksz9477_set_wol(struct ksz_device *dev, int port,
> +		    struct ethtool_wolinfo *wol)
> +{
> +	u8 pme_conf, pme_ctrl = 0;
> +	int ret;
> +
> +	if (wol->wolopts & ~WAKE_PHY)
> +		return -EINVAL;

EOPNOTSUPP might be better here. I'm assuming there is no other way
WoL can be supported, since this is a combined MAC/PHY device. 

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew