[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZS6fbVtbuBH32aRU@lizhi-Precision-Tower-5810>
Date: Tue, 17 Oct 2023 10:51:25 -0400
From: Frank Li <Frank.li@....com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: alexandre.belloni@...tlin.com, conor.culhane@...vaco.com,
joe@...ches.com, linux-i3c@...ts.infradead.org,
linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 1/5] i3c: master: svc: enable hotjoin default
On Tue, Oct 17, 2023 at 04:04:57PM +0200, Miquel Raynal wrote:
> Hi Frank,
>
> Frank.Li@....com wrote on Mon, 16 Oct 2023 11:46:28 -0400:
>
> > Hotjoin require clock running and enable SLVSTART irq.
> > Add module parameter 'hotjoin' to disable hotjoin and enable runtime_pm to
> > save power.
>
> I am really not a big fan of the use of modules parameters. Maybe it
> makes sense here. Alex, a better idea?
Maybe we can create sys entry to enable/disable hotjoin. I think i3c
should default support hotjoin, but it exist user case that needn't hj and
want more aggressive power saving.
If create /sys/ entry, it need change driver/i3c/master.c.
Frank
>
> Thanks,
> Miquèl
Powered by blists - more mailing lists