linux-kernel - Re: [PATCH 5.15 000/102] 5.15.136-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8cd1f099-b16e-4db8-91d8-ae1ad974bf08@oracle.com>
Date:   Tue, 17 Oct 2023 17:09:04 +0200
From:   Vegard Nossum <vegard.nossum@...cle.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
        stable@...r.kernel.org, Sasha Levin <sashal@...nel.org>,
        patches@...ts.linux.dev, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, sudipm.mukherjee@...il.com,
        srw@...dewatkins.net, rwarsow@....de, conor@...nel.org
Subject: Re: [PATCH 5.15 000/102] 5.15.136-rc1 review


On 17/10/2023 16:08, Greg Kroah-Hartman wrote:
> On Tue, Oct 17, 2023 at 03:57:06PM +0200, Greg Kroah-Hartman wrote:
>> Sure!  Here's the output, good luck!
>>
>> $ make -C tools/perf
>> make: Entering directory '/home/gregkh/linux/stable/linux-5.15.y/tools/perf'
>>    BUILD:   Doing 'make -j20' parallel build
>> Warning: Kernel ABI header at 'tools/include/uapi/linux/const.h' differs from latest version at 'include/uapi/linux/const.h'
>> diff -u tools/include/uapi/linux/const.h include/uapi/linux/const.h
>> Warning: Kernel ABI header at 'tools/include/uapi/linux/in.h' differs from latest version at 'include/uapi/linux/in.h'
>> diff -u tools/include/uapi/linux/in.h include/uapi/linux/in.h
>> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/disabled-features.h' differs from latest version at 'arch/x86/include/asm/disabled-features.h'
>> diff -u tools/arch/x86/include/asm/disabled-features.h arch/x86/include/asm/disabled-features.h
>> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/required-features.h' differs from latest version at 'arch/x86/include/asm/required-features.h'
>> diff -u tools/arch/x86/include/asm/required-features.h arch/x86/include/asm/required-features.h
>> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/cpufeatures.h' differs from latest version at 'arch/x86/include/asm/cpufeatures.h'
>> diff -u tools/arch/x86/include/asm/cpufeatures.h arch/x86/include/asm/cpufeatures.h
>> Warning: Kernel ABI header at 'tools/arch/x86/include/asm/msr-index.h' differs from latest version at 'arch/x86/include/asm/msr-index.h'
>> diff -u tools/arch/x86/include/asm/msr-index.h arch/x86/include/asm/msr-index.h
>> Warning: Kernel ABI header at 'tools/arch/arm64/include/uapi/asm/kvm.h' differs from latest version at 'arch/arm64/include/uapi/asm/kvm.h'
>> diff -u tools/arch/arm64/include/uapi/asm/kvm.h arch/arm64/include/uapi/asm/kvm.h
>> Makefile.config:1036: No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev
>> Makefile.config:1062: No alternatives command found, you need to set JDIR= to point to the root of your Java directory
>> tests/bpf.c: In function ‘epoll_pwait_loop’:
>> tests/bpf.c:36:17: error: argument 2 null where non-null expected [-Werror=nonnull]
>>     36 |                 epoll_pwait(-(i + 1), NULL, 0, 0, NULL);
>>        |                 ^~~~~~~~~~~
>> In file included from tests/bpf.c:5:
>> /usr/include/sys/epoll.h:134:12: note: in a call to function ‘epoll_pwait’ declared ‘nonnull’
>>    134 | extern int epoll_pwait (int __epfd, struct epoll_event *__events,
>>        |            ^~~~~~~~~~~
> 
> <snip>
> 
> Also, in Linus's tree, this works just fine on my system, but I get this
> same error above (and only this error), when building perf on 6.1.y, and
> on 6.5.y.  The perl errors are not present there.

So lots of those are -Werror things -- I'm guessing it's a newer
compiler/toolchain/libraries on an older tree. There might be some
commits in mainline fixing those... in the meantime, what happens if you
just disable -Werror for now?

     make -C tools/perf/ WERROR=0

If that doesn't work, maybe even:

     make -C tools/perf/ WERROR=0 NO_LIBPERL=1

There are a bunch of other options to disable various things, they are
all documented in tools/perf/Makefile.perf.


Vegard