linux-kernel - Re: [PATCH v4 4/5] misc: fastrpc: Add support to save and restore interrupted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023101743-discern-plunging-83e4@gregkh>
Date:   Tue, 17 Oct 2023 18:10:08 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ekansh Gupta <quic_ekangupt@...cinc.com>
Cc:     srinivas.kandagatla@...aro.org, linux-arm-msm@...r.kernel.org,
        ekangupt@....qualcomm.com, linux-kernel@...r.kernel.org,
        fastrpc.upstream@....qualcomm.com
Subject: Re: [PATCH v4 4/5] misc: fastrpc: Add support to save and restore
 interrupted

On Tue, Oct 17, 2023 at 08:36:28PM +0530, Ekansh Gupta wrote:
> 
> On 10/17/2023 6:50 PM, Greg KH wrote:
> > On Tue, Oct 17, 2023 at 02:56:38PM +0530, Ekansh Gupta wrote:
> > > For any remote call, driver sends a message to DSP using RPMSG
> > > framework. After message is sent, there is a wait on a completion
> > > object at driver which is completed when DSP response is received.
> > > 
> > > There is a possibility that a signal is received while waiting
> > > causing the wait function to return -ERESTARTSYS. In this case
> > > the context should be saved and it should get restored for the
> > > next invocation for the thread.
> > > 
> > > Adding changes to support saving and restoring of interrupted
> > > fastrpc contexts.
> > > 
> > > Signed-off-by: Ekansh Gupta <quic_ekangupt@...cinc.com>
> > > Change-Id: Ia101acf7c1bf6018635536082bf7ea009093c948
> > > ---
> > > Changes in v2:
> > >    - Fixed missing definition
> > >    - Fixes compile time issue
> > You forgot to run checkpatch.pl :(
> 
> I did run checkpatch.pl and also tried compilation test. checkpatch.pl is
> suggesting 0 errors, 0 warning and compilation also worked without any
> errors. I might have checked on last week's base as there were no changes in
> these files. I'll check the patches with latest version and update again if
> any errors/warnings are observed. Thanks for reviewing the patch. -ekansh

The "Change-Id:" should not be there, and I thought checkpatch would
catch that.  If not, no big deal, you should have :)