linux-kernel - Re: [PATCH v3 0/4] HID: touchscreen: add himax hid-over-spi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c7d9c92-7616-4fad-806e-44302c33b63c@linaro.org>
Date:   Tue, 17 Oct 2023 19:08:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Tylor Yang <tylor_yang@...ax.corp-partner.google.com>,
        Doug Anderson <dianders@...omium.org>,
        Tomasz Figa <tfiga@...omium.org>, jingyliang@...omium.org,
        poyuan_chang@...ax.corp-partner.google.com, hbarnor@...omium.org
Cc:     jikos@...nel.org, wuxy23@...ovo.com, conor+dt@...nel.org,
        luolm1@...ovo.com, robh+dt@...nel.org, dmitry.torokhov@...il.com,
        devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        poyu_hung@...ax.corp-partner.google.com,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        benjamin.tissoires@...hat.com
Subject: Re: [PATCH v3 0/4] HID: touchscreen: add himax hid-over-spi driver

On 17/10/2023 11:18, Tylor Yang wrote:
> Hello,
> 
> This patch series adds the driver for Himax HID-over-SPI touchscreen ICs.
> This driver takes a position in [1], it intends to take advantage of SPI
> transfer speed and HID interface.
> 

Dear Google/Chromium folks,

As a multi-billion company I am sure you can spare some small amount of
time/effort/money for internal review before using community for this
purpose. I mean reviewing trivial issues, like coding style, or just
running checkpatch. You know, the obvious things.

There is no need to use expensive time of community reviewers to review
very simple mistakes, the ones which we fixed in Linux kernel years ago
(also with automated tools). You can and you should do it, before
submitting drivers for community review.

Thanks in advance.

Best regards,
Krzysztof