linux-kernel - [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231017194657.3199749-1-Frank.Li@nxp.com>
Date:   Tue, 17 Oct 2023 15:46:56 -0400
From:   Frank Li <Frank.Li@....com>
To:     miquel.raynal@...tlin.com
Cc:     Frank.Li@....com, alexander.stein@...tq-group.com,
        alexandre.belloni@...tlin.com, conor+dt@...nel.org,
        conor.culhane@...vaco.com, conor@...nel.org,
        devicetree@...r.kernel.org, festevam@...il.com, haibo.chen@....com,
        imx@...ts.linux.dev, joe@...ches.com, kernel@...gutronix.de,
        krzysztof.kozlowski+dt@...aro.org, krzysztof.kozlowski@...aro.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-i3c@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, peng.fan@....com, ping.bai@....com,
        robh+dt@...nel.org, s.hauer@...gutronix.de, shawnguo@...nel.org,
        sherry.sun@....com, xiaoning.wang@....com
Subject: [PATCH v2 1/2] i3c: master: svc: fix compatibility string mismatch with binding doc

In the binding documentation, the compatible string is specified as
'silvaco,i3c-master-v1', but in the driver, it is defined as
'silvaco,i3c-master'.

Rename 'silvaco,i3c-master' to 'silvaco,i3c-master-v1' to ensure
compatibility with the documentation.

Signed-off-by: Frank Li <Frank.Li@....com>
---

Notes:
    Change from v2 to v3
    - Miquèl think drop silvaco,i3c-master totally. I grep dts tree. No
    upstream dts use silvaco,i3c-master yet.
      I have not add "Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>",
    it is different solution with previous one even just one line change.
      I think v2/v3 both is good, feel free to pick each one.
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1
    
    Change from v1 to v2
    - update driver by using compatible string silvaco,i3c-master-v1

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index cf932ee056ef9..e307ba2b965e6 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -1650,7 +1650,7 @@ static const struct dev_pm_ops svc_i3c_pm_ops = {
 };
 
 static const struct of_device_id svc_i3c_master_of_match_tbl[] = {
-	{ .compatible = "silvaco,i3c-master" },
+	{ .compatible = "silvaco,i3c-master-v1"},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, svc_i3c_master_of_match_tbl);
-- 
2.34.1