linux-kernel - Re: [PATCH] landlock: fix typo in landlock_append_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231017.ia3Aiv5Am5ee@digikod.net>
Date:   Tue, 17 Oct 2023 21:48:10 +0200
From:   Mickaël Salaün <mic@...ikod.net>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
        Arnd Bergmann <arnd@...db.de>,
        linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] landlock: fix typo in landlock_append_net_rule() stub
 function

Thanks Arnd, I fixed the issue and squashed it in -next.

There will be a next patch series including other fixes.

On Tue, Oct 17, 2023 at 04:33:35PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> There is an extraneous semicolon in the empty stub helper for
> this function tha causes randconfig builds to break:
> 
> In file included from security/landlock/setup.c:17:
> security/landlock/net.h:28:1: error: expected identifier or '(' before '{' token
> security/landlock/net.h:26:1: error: 'landlock_append_net_rule' declared 'static' but never defined [-Werror=unused-function]
> 
> Fixes: 614d46b333ab9 ("landlock: Add network rules and TCP hooks support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  security/landlock/net.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/landlock/net.h b/security/landlock/net.h
> index 588a49fd69076..09960c237a13e 100644
> --- a/security/landlock/net.h
> +++ b/security/landlock/net.h
> @@ -24,7 +24,7 @@ static inline void landlock_add_net_hooks(void)
>  
>  static inline int
>  landlock_append_net_rule(struct landlock_ruleset *const ruleset, const u16 port,
> -			 access_mask_t access_rights);
> +			 access_mask_t access_rights)
>  {
>  	return -EAFNOSUPPORT;
>  }
> -- 
> 2.39.2
>