linux-kernel - Re: [PATCH v2 2/6] iommufd/hw_pagetable: Use domain_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9982749e-b6c4-43d6-cea0-2da5abb3ed17@intel.com>
Date:   Tue, 17 Oct 2023 11:46:06 +0800
From:   "Liu, Jingqi" <jingqi.liu@...el.com>
To:     Nicolin Chen <nicolinc@...dia.com>
CC:     Yi Liu <yi.l.liu@...el.com>, <joro@...tes.org>,
        <alex.williamson@...hat.com>, <jgg@...dia.com>,
        <kevin.tian@...el.com>, <robin.murphy@....com>,
        <baolu.lu@...ux.intel.com>, <cohuck@...hat.com>,
        <eric.auger@...hat.com>, <kvm@...r.kernel.org>,
        <mjrosato@...ux.ibm.com>, <chao.p.peng@...ux.intel.com>,
        <yi.y.sun@...ux.intel.com>, <peterx@...hat.com>,
        <jasowang@...hat.com>, <shameerali.kolothum.thodi@...wei.com>,
        <lulu@...hat.com>, <suravee.suthikulpanit@....com>,
        <iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>, <zhenzhong.duan@...el.com>,
        <joao.m.martins@...cle.com>
Subject: Re: [PATCH v2 2/6] iommufd/hw_pagetable: Use domain_alloc_user op for
 domain allocation


On 10/17/2023 1:48 AM, Nicolin Chen wrote:
> On Mon, Oct 16, 2023 at 04:16:05PM +0800, Liu, Jingqi wrote:
>   
>> @@ -88,10 +90,19 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx, struct iommufd_ioas *ioas,
>>         refcount_inc(&ioas->obj.users);
>>         hwpt->ioas = ioas;
>>
>> -       hwpt->domain = iommu_domain_alloc(idev->dev->bus);
>> -       if (!hwpt->domain) {
>> -               rc = -ENOMEM;
>> -               goto out_abort;
>> +       if (ops->domain_alloc_user) {
>> +               hwpt->domain = ops->domain_alloc_user(idev->dev, 0);
>>
>> Seems a "flags" parameter needs to be passed to 'domain_alloc_user()'.
>> Like this:
>>          hwpt->domain = ops->domain_alloc_user(idev->dev, flags);
> 
> There's no "flags" parameter until the following PATCH-3:
> https://lore.kernel.org/linux-iommu/20230928071528.26258-4-yi.l.liu@intel.com/
> 
Yes. I had noticed that "flags" parameter is added in PATCH-3.
Thanks for your clarification.

BR,
Jingqi

> Thanks
> Nicolin