linux-kernel - Re: [PATCH v3] selftests/user_events: Fix abi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38a36f4c-c62a-44f0-a818-3ea7dc49654b@linuxfoundation.org>
Date:   Tue, 17 Oct 2023 15:10:48 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Beau Belgrave <beaub@...ux.microsoft.com>
Cc:     shuah@...nel.org, mhiramat@...nel.org,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        linux-trace-kernel@...r.kernel.org,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3] selftests/user_events: Fix abi_test for BE archs

On 10/17/23 14:38, Steven Rostedt wrote:
> On Thu,  5 Oct 2023 21:57:12 +0000
> Beau Belgrave <beaub@...ux.microsoft.com> wrote:
> 
>> The abi_test currently uses a long sized test value for enablement
>> checks. On LE this works fine, however, on BE this results in inaccurate
>> assert checks due to a bit being used and assuming it's value is the
>> same on both LE and BE.
>>
>> Use int type for 32-bit values and long type for 64-bit values to ensure
>> appropriate behavior on both LE and BE.
>>
>> Fixes: 60b1af8de8c1 ("tracing/user_events: Add ABI self-test")
>> Signed-off-by: Beau Belgrave <beaub@...ux.microsoft.com>
>> ---
>> V3 Changes:
>> Fix missing cast in clone_check().
>>
>> V2 Changes:
>> Rebase to linux-kselftest/fixes.
> 
> Shuah,
> 
> Can you take this patch?
> 
> Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>
> 

Thank you both. Applied to linux-kselftest fixes for Linux 6.6-rc7

thanks,
-- Shuah