linux-kernel - Re: [PATCH net-next 6/8] dt-bindings: net: mscc,vsc7514-switch: Clean-up example indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1864d057-3b9c-447a-9f00-c8ad2fbb74d1@arinc9.com>
Date:   Tue, 17 Oct 2023 09:43:53 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Rob Herring <robh@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Clément Léger <clement.leger@...tlin.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Maxime Ripard <mripard@...nel.org>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Daniel Golle <daniel@...rotopia.org>,
        John Crispin <john@...ozen.org>,
        Gerhard Engleder <gerhard@...leder-embedded.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Justin Chen <justin.chen@...adcom.com>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Sekhar Nori <nsekhar@...com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org,
        linux-renesas-soc@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH net-next 6/8] dt-bindings: net: mscc,vsc7514-switch:
 Clean-up example indentation

On 17.10.2023 00:44, Rob Herring wrote:
> The indentation for the example is completely messed up for
> 'ethernet-ports'. Fix it.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   .../bindings/net/mscc,vsc7514-switch.yaml          | 32 +++++++++++-----------
>   1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> index 8ee2c7d7ff42..07de52a3a295 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -185,7 +185,7 @@ examples:
>       };
>     # VSC7512 (DSA)
>     - |
> -    ethernet-switch@1{
> +    ethernet-switch@1 {
>         compatible = "mscc,vsc7512-switch";
>         reg = <0x71010000 0x10000>,
>               <0x71030000 0x10000>,
> @@ -212,22 +212,22 @@ examples:
>               "port7", "port8", "port9", "port10", "qsys",
>               "ana", "s0", "s1", "s2";
>   
> -            ethernet-ports {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> -
> -           port@0 {
> -            reg = <0>;
> -            ethernet = <&mac_sw>;
> -            phy-handle = <&phy0>;
> -            phy-mode = "internal";
> -          };
> -          port@1 {
> -            reg = <1>;
> -            phy-handle = <&phy1>;
> -            phy-mode = "internal";
> -          };
> +      ethernet-ports {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        port@0 {
> +          reg = <0>;
> +          ethernet = <&mac_sw>;
> +          phy-handle = <&phy0>;
> +          phy-mode = "internal";
> +        };

Could use 4-space indentation as described here.

https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-schema.html#example-schema

Regardless:

Acked-by: Arınç ÜNAL <arinc.unal@...nc9.com>

Arınç