linux-kernel - Re: [PATCH v2] staging: rtl8192u: Remove broken driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e02936c7-2176-4298-a335-4d4ecf484bb9@leemhuis.info>
Date:   Tue, 17 Oct 2023 09:42:43 +0200
From:   Thorsten Leemhuis <linux@...mhuis.info>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Arnd Bergmann <arnd@...db.de>, Kalle Valo <kvalo@...nel.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2] staging: rtl8192u: Remove broken driver

On 17.10.23 09:20, Greg Kroah-Hartman wrote:
> On Tue, Oct 17, 2023 at 07:33:49AM +0200, Thorsten Leemhuis wrote:
>> On 14.10.23 23:10, Philipp Hortmann wrote:
>>> Tests on rtl8192u hardware have shown that this driver is broken since
>>> 2016. Remove broken driver. Find fix for two bugs in second link.
>>>
>>> Link: https://lore.kernel.org/lkml/db98d9ac-7650-4a72-8eb9-4def1f17ea0d@app.fastmail.com/
>>> Link: https://lore.kernel.org/lkml/cover.1697089416.git.philipp.g.hortmann@gmail.com/
>>> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
>>> ---
>>> V2: Added 2x links and adapted description.
>>>
>>> Did not find any artifacts of rtl8192u in MAINTAINERS.
>>> ---
>>>  drivers/staging/Kconfig                       |    2 -
>>>  drivers/staging/rtl8192u/Kconfig              |   12 -
>>> [...]
>>
>> My daily linux-next builds for Fedora (based on Fedora rawhide config)
>> failed today with this error msg:
>>
>> """
>> + /usr/bin/make -s 'HOSTCFLAGS=-O2  -fexceptions -g
>> -grecord-gcc-switches -pipe -Wall -Werror=format-security
>> -Werror=implicit-function-declaration -Werror=implicit-int
>> -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS
>> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong
>> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64 -mcpu=power8
>> -mtune=power8 -fasynchronous-unwind-tables -fstack-clash-protection '
>> 'HOSTLDFLAGS=-Wl,-z,relro -Wl,--as-needed  -Wl,-z,now
>> -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
>> -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1
>> -specs=/usr/lib/rpm/redhat/redhat-package-notes ' -j2 mrproper
>> scripts/Makefile.clean:12: drivers/staging/rtl8192u/Makefile: No such
>> file or directory
>> make[5]: *** No rule to make target 'drivers/staging/rtl8192u/Makefile'.
>>  Stop.
>> make[4]: *** [scripts/Makefile.clean:61: drivers/staging/rtl8192u] Error 2
>> make[3]: *** [scripts/Makefile.clean:61: drivers/staging] Error 2
>> make[3]: *** Waiting for unfinished jobs....
>> make[2]: *** [scripts/Makefile.clean:61: drivers] Error 2
>> make[1]: ***
>> [/builddir/build/BUILD/kernel-next-20231017/linux-6.6.0-0.0.next.20231017.447.vanilla.fc40.ppc64le/Makefile:1920:
>> _clean_.] Error 2
>> make: *** [Makefile:236: __sub-make] Error 2
>> error: Bad exit status from /var/tmp/rpm-tmp.TJDlJV (%build)
>> """
>>
>> Full log:
>> https://copr-be.cloud.fedoraproject.org/results/@kernel-vanilla/next/fedora-rawhide-ppc64le/06536998-next-next-all/builder-live.log.gz
>>
>> Made me wonder if this patch left something behind; a quick grep showed
>> something suspicious in drivers/staging/Makefile:
>> """
>> obj-$(CONFIG_RTL8192U)		+= rtl8192u/
>> """
> 
> If you did 'make oldconfig' the option should have been removed and then
> this line wouldn't have triggered, right?

Guess so, but apparently Fedora's rpm spec file runs the failing "make
mrproper" before running 'make oldconfig'.

>  Odd, but I'll go drop this entry as well.

Great, thx!

Ciao, Thorsten