[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2059ea42-f5cb-1366-804e-7036fb40cdaa@huawei.com>
Date: Tue, 17 Oct 2023 15:56:48 +0800
From: Yunsheng Lin <linyunsheng@...wei.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <davem@...emloft.net>, <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Jesper Dangaard Brouer <hawk@...nel.org>,
John Fastabend <john.fastabend@...il.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, <bpf@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH net-next v11 0/6] introduce page_pool_alloc() related API
On 2023/10/17 9:27, Jakub Kicinski wrote:
> On Fri, 13 Oct 2023 14:48:20 +0800 Yunsheng Lin wrote:
>> v5 RFC: Add a new page_pool_cache_alloc() API, and other minor
>> change as discussed in v4. As there seems to be three
>> comsumers that might be made use of the new API, so
>> repost it as RFC and CC the relevant authors to see
>> if the new API fits their need.
>
> I have looked thru the v4 discussion (admittedly it was pretty huge).
> I can't find where the "cache" API was suggested.
Actually, the discussion happened in V3 as both of discussions in V3
and V4 seems to be happening concurrently:
https://lore.kernel.org/all/f8ce176f-f975-af11-641c-b56c53a8066a@redhat.com/
> And I can't figure out now what the "cache" in the name is referring to.
> Looks like these are just convenience wrappers which return VA instead
> of struct page..
Yes, it is corresponding to some API like napi_alloc_frag() returning va
instead of 'struct page' mentioned in patch 5.
Anyway, naming is hard, any suggestion for a better naming is always
welcomed:)
> .
>
Powered by blists - more mailing lists