linux-kernel - Re: [PATCH -next v2 17/19] mm: convert wp_page_reuse() and finish_mkwrite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b52105b5-3910-46b8-a869-4a82c8a2b845@huawei.com>
Date:   Tue, 17 Oct 2023 17:04:41 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     kernel test robot <lkp@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <oe-kbuild-all@...ts.linux.dev>,
        Linux Memory Management List <linux-mm@...ck.org>,
        <willy@...radead.org>, <linux-kernel@...r.kernel.org>,
        <ying.huang@...el.com>, <david@...hat.com>,
        Zi Yan <ziy@...dia.com>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH -next v2 17/19] mm: convert wp_page_reuse() and
 finish_mkwrite_fault() to take a folio



On 2023/10/17 15:33, kernel test robot wrote:
> Hi Kefeng,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on akpm-mm/mm-everything]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Kefeng-Wang/mm_types-add-virtual-and-_last_cpupid-into-struct-folio/20231017-121040
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
> patch link:    https://lore.kernel.org/r/20231013085603.1227349-18-wangkefeng.wang%40huawei.com
> patch subject: [PATCH -next v2 17/19] mm: convert wp_page_reuse() and finish_mkwrite_fault() to take a folio
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310171537.XhmrkImn-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310171537.XhmrkImn-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310171537.XhmrkImn-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
>>> mm/memory.c:3276: warning: Function parameter or member 'folio' not described in 'finish_mkwrite_fault'
> 

Hi Andrew, should I resend this patch? or could you help me to update
it, also a comment(page -> folio's) on patch18, thanks.

> 
> vim +3276 mm/memory.c
> 
> 2f38ab2c3c7fef Shachar Raindel 2015-04-14  3258
> 66a6197c118540 Jan Kara        2016-12-14  3259  /**
> 66a6197c118540 Jan Kara        2016-12-14  3260   * finish_mkwrite_fault - finish page fault for a shared mapping, making PTE
> 66a6197c118540 Jan Kara        2016-12-14  3261   *			  writeable once the page is prepared
> 66a6197c118540 Jan Kara        2016-12-14  3262   *
> 66a6197c118540 Jan Kara        2016-12-14  3263   * @vmf: structure describing the fault
> 66a6197c118540 Jan Kara        2016-12-14  3264   *
> 66a6197c118540 Jan Kara        2016-12-14  3265   * This function handles all that is needed to finish a write page fault in a
> 66a6197c118540 Jan Kara        2016-12-14  3266   * shared mapping due to PTE being read-only once the mapped page is prepared.
> a862f68a8b3600 Mike Rapoport   2019-03-05  3267   * It handles locking of PTE and modifying it.
> 66a6197c118540 Jan Kara        2016-12-14  3268   *
> 66a6197c118540 Jan Kara        2016-12-14  3269   * The function expects the page to be locked or other protection against
> 66a6197c118540 Jan Kara        2016-12-14  3270   * concurrent faults / writeback (such as DAX radix tree locks).
> a862f68a8b3600 Mike Rapoport   2019-03-05  3271   *
> 2797e79f1a491f Liu Xiang       2021-06-28  3272   * Return: %0 on success, %VM_FAULT_NOPAGE when PTE got changed before
> a862f68a8b3600 Mike Rapoport   2019-03-05  3273   * we acquired PTE lock.
> 66a6197c118540 Jan Kara        2016-12-14  3274   */
> 60fe935fc6b035 Kefeng Wang     2023-10-13  3275  static vm_fault_t finish_mkwrite_fault(struct vm_fault *vmf, struct folio *folio)
> 66a6197c118540 Jan Kara        2016-12-14 @3276  {
> 66a6197c118540 Jan Kara        2016-12-14  3277  	WARN_ON_ONCE(!(vmf->vma->vm_flags & VM_SHARED));
> 66a6197c118540 Jan Kara        2016-12-14  3278  	vmf->pte = pte_offset_map_lock(vmf->vma->vm_mm, vmf->pmd, vmf->address,
> 66a6197c118540 Jan Kara        2016-12-14  3279  				       &vmf->ptl);
> 3db82b9374ca92 Hugh Dickins    2023-06-08  3280  	if (!vmf->pte)
> 3db82b9374ca92 Hugh Dickins    2023-06-08  3281  		return VM_FAULT_NOPAGE;
> 66a6197c118540 Jan Kara        2016-12-14  3282  	/*
> 66a6197c118540 Jan Kara        2016-12-14  3283  	 * We might have raced with another page fault while we released the
> 66a6197c118540 Jan Kara        2016-12-14  3284  	 * pte_offset_map_lock.
> 66a6197c118540 Jan Kara        2016-12-14  3285  	 */
> c33c794828f212 Ryan Roberts    2023-06-12  3286  	if (!pte_same(ptep_get(vmf->pte), vmf->orig_pte)) {
> 7df676974359f9 Bibo Mao        2020-05-27  3287  		update_mmu_tlb(vmf->vma, vmf->address, vmf->pte);
> 66a6197c118540 Jan Kara        2016-12-14  3288  		pte_unmap_unlock(vmf->pte, vmf->ptl);
> a19e25536ed3a2 Jan Kara        2016-12-14  3289  		return VM_FAULT_NOPAGE;
> 66a6197c118540 Jan Kara        2016-12-14  3290  	}
> 60fe935fc6b035 Kefeng Wang     2023-10-13  3291  	wp_page_reuse(vmf, folio);
> a19e25536ed3a2 Jan Kara        2016-12-14  3292  	return 0;
> 66a6197c118540 Jan Kara        2016-12-14  3293  }
> 66a6197c118540 Jan Kara        2016-12-14  3294
>