lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d77f35a3-5eec-d02f-459b-1968a58ff7d5@intel.com>
Date:   Tue, 17 Oct 2023 11:07:49 +0200
From:   Karolina Stolarek <karolina.stolarek@...el.com>
To:     Gilbert Adikankwu <gilbertadikankwu@...il.com>
CC:     Philipp Hortmann <philipp.g.hortmann@...il.com>,
        <outreachy@...ts.linux.dev>, <forest@...ttletooquiet.net>,
        <gregkh@...uxfoundation.org>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 0/4] Rename variable bUpdateBBVGA, byCurrentCh, byCurPwr
 and byBBPreEDRSSI

On 17.10.2023 09:19, Gilbert Adikankwu wrote:
> On Tue, Oct 17, 2023 at 08:19:49AM +0200, Philipp Hortmann wrote:
>> On 10/17/23 00:58, Gilbert Adikankwu wrote:
>>> Make the variable names adhere to Linux kernel coding style and mute
>>> checkpatch.pl errors.

A small nit from my side -- "mute" suggests that you suppressed the 
warning/error, but your changes fix them, so why now say "fix 
checkpatch.pl errors"?

>>>
>>> Gilbert Adikankwu (4):
>>>     staging: vt6655: Rename variable bUpdateBBVGA
>>>     staging: vt6655: Rename variable byCurrentCh
>>>     staging: vt6655: Rename variable byCurPwr
>>>     staging: vt6655: Rename variable byBBPreEDRSSI
>>>
>>>    drivers/staging/vt6655/baseband.c    |  2 +-
>>>    drivers/staging/vt6655/channel.c     | 18 +++++++++---------
>>>    drivers/staging/vt6655/device.h      |  8 ++++----
>>>    drivers/staging/vt6655/device_main.c |  8 ++++----
>>>    drivers/staging/vt6655/dpc.c         |  2 +-
>>>    drivers/staging/vt6655/rf.c          |  4 ++--
>>>    6 files changed, 21 insertions(+), 21 deletions(-)
>>>
>>
>> Hi,
>>
>> -       if (priv->byCurrentCh == ch->hw_value)
>> +       if (priv->current_ch == ch->hw_value)^M
>>                  return ret;
>>
>> ERROR: DOS line endings
>>
>> What does the "^M" at the end of the new line?
>> Did you run checkpatch on your patches?
>>
>> Thanks
>>
>> Bye
>>
>> Philipp
> 
> Hello,
> 
> I do not know what this error means. If anything, I'm surprised there is
> an error. checkpatch is hooked to my git commit and all the patches
> built cleanly on my machine. I will resend now.

I'm not seeing that error when the patch is applied. You could 
double-check the patch files before sending by calling checkpatch.pl on 
them directly.

This could be also because of how some email clients change the endings 
on download, like Thunderbird, and the patch itself might be fine.

All the best,
Karolina

> 
> Thanks
> Gilbert
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ