linux-kernel - Re: [PATCH] ARM: dts: exynos: fix input keys with Linux event codes for midas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7708e8fd-7b47-46c1-a98f-b1521620d5d2@linaro.org>
Date:   Tue, 17 Oct 2023 11:51:43 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Raymond Hackley <raymondhackley@...tonmail.com>,
        linux-kernel@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH] ARM: dts: exynos: fix input keys with Linux event codes
 for midas

On 17/10/2023 11:21, Raymond Hackley wrote:
> Input event code 139 stands for KEY_MENU, instead of KEY_OK as key-ok
> inplies. Fix all event codes with linux-event-codes.h included for midas.

Please re-phrase the subject and commit msg. If you replace numbers to
defines, which are eventually numbers as well, it is not a fix. There is
nothing to fix here.

If you fix actual key code from incorrect one to correct one, this must
be clearly stated and a separate commit..



Best regards,
Krzysztof