linux-kernel - Re: [PATCH net-next v2 00/11] devlink: retain error in struct devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZS5tR1z5rHuD8BFD@nanopsycho>
Date:   Tue, 17 Oct 2023 13:17:27 +0200
From:   Jiri Pirko <jiri@...nulli.us>
To:     Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Shannon Nelson <shannon.nelson@....com>,
        Michael Chan <michael.chan@...adcom.com>,
        Cai Huoqing <cai.huoqing@...ux.dev>,
        George Cherian <george.cherian@...vell.com>,
        Danielle Ratson <danieller@...dia.com>,
        Moshe Shemesh <moshe@...dia.com>,
        Saeed Mahameed <saeedm@...dia.com>,
        Ariel Elior <aelior@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        Igor Russkikh <irusskikh@...vell.com>,
        Coiby Xu <coiby.xu@...il.com>,
        Brett Creeley <brett.creeley@....com>,
        Sunil Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geetha sowjanya <gakula@...vell.com>,
        Jerin Jacob <jerinj@...vell.com>,
        hariprasad <hkelam@...vell.com>,
        Subbaraya Sundeep <sbhatta@...vell.com>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Eran Ben Elisha <eranbe@...dia.com>,
        Aya Levin <ayal@...lanox.com>,
        Leon Romanovsky <leon@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 00/11] devlink: retain error in struct
 devlink_fmsg

Tue, Oct 17, 2023 at 12:53:30PM CEST, przemyslaw.kitszel@...el.com wrote:
>Extend devlink fmsg to retain error (patch 1),
>so drivers could omit error checks after devlink_fmsg_*() (patches 2-10),
>and finally enforce future uses to follow this practice by change to
>return void (patch 11)
>
>Note that it was compile tested only.
>
>bloat-o-meter for whole series:
>add/remove: 8/18 grow/shrink: 23/40 up/down: 2017/-5833 (-3816)
>
>changelog:
>v2: extend series by two more drivers (qed, qlge);
>    add final cleanup patch, since now whole series should be merged in
>    one part (thanks Jiri for encouragement here);
>
>v1:
>https://lore.kernel.org/netdev/20231010104318.3571791-3-przemyslaw.kitszel@intel.com
>
>Przemek Kitszel (11):
>  devlink: retain error in struct devlink_fmsg
>  netdevsim: devlink health: use retained error fmsg API
>  pds_core: devlink health: use retained error fmsg API
>  bnxt_en: devlink health: use retained error fmsg API
>  hinic: devlink health: use retained error fmsg API
>  octeontx2-af: devlink health: use retained error fmsg API
>  mlxsw: core: devlink health: use retained error fmsg API
>  net/mlx5: devlink health: use retained error fmsg API
>  qed: devlink health: use retained error fmsg API
>  staging: qlge: devlink health: use retained error fmsg API
>  devlink: convert most of devlink_fmsg_*() to return void

Looks great.

Thanks!

set-
Reviewed-by: Jiri Pirko <jiri@...dia.com>