linux-kernel - Re: [PATCH] drm/msm/a6xx: add QMP dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <044c2493-1294-4760-8e33-51f631265d59@linaro.org>
Date:   Tue, 17 Oct 2023 14:24:52 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Arnd Bergmann <arnd@...nel.org>, Rob Clark <robdclark@...il.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     Arnd Bergmann <arnd@...db.de>, Sean Paul <sean@...rly.run>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Randy Dunlap <rdunlap@...radead.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Akhil P Oommen <quic_akhilpo@...cinc.com>,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/a6xx: add QMP dependency



On 10/16/23 22:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When QMP is in a loadable module, the A6xx GPU driver fails to link
> as built-in:
> 
> x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
> a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'
> 
> Add the usual dependency that still allows compiling without QMP but
> otherwise avoids the broken combination of options.
> 
> Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
Right, thanks!

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad