linux-kernel - Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around pinctrl_gpio_direction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZS6BAkfFeA+6GYfz@smile.fi.intel.com>
Date:   Tue, 17 Oct 2023 15:41:38 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v3 54/73] pinctrl: intel: drop the wrappers around
 pinctrl_gpio_direction_input()

On Tue, Oct 17, 2023 at 02:04:12PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> pinctrl_gpio_direction_input() now has the same signature as the
> wrappers around it so we can drop them.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

Now, for the sake of symmetry can you add (at least to the all
Intel drivers you modified in this series) the following:


int pinctrl_gpio_direction_output_with_value(struct gpio_chip *gc,
					     unsigned int offset, int value)
{
	gc->set(gc, offset, value);
        return pinctrl_gpio_direction_output(gc, offset);
}


?

And respectively in this driver

	.direction_output = pincttl_gpio_direction_output_with_value,


-- 
With Best Regards,
Andy Shevchenko