[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20231017124234.99574-1-guangguan.wang@linux.alibaba.com>
Date: Tue, 17 Oct 2023 20:42:32 +0800
From: Guangguan Wang <guangguan.wang@...ux.alibaba.com>
To: kgraul@...ux.ibm.com, wenjia@...ux.ibm.com, jaka@...ux.ibm.com,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com
Cc: tonylu@...ux.alibaba.com, alibuda@...ux.alibaba.com,
guwen@...ux.alibaba.com, linux-s390@...r.kernel.org,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH net v2 0/2] net/smc: correct the reason code in smc_listen_find_device when fallback
The function smc_find_ism_store_rc is not only used for ism, so it is
reasonable to change the function name to smc_find_device_store_rc.
The ini->rc is used to store the last error happened when finding usable
ism or rdma device in smc_listen_find_device, and is set by calling smc_
find_device_store_rc. Once the ini->rc is assigned to an none-zero value,
the value can not be overwritten anymore. So the ini-rc should be set to
the error reason only when an error actually occurs.
When finding ISM/RDMA devices, device not found is not a real error, as
not all machine have ISM/RDMA devices. Failures after device found, when
initializing device or when initializing connection, is real errors, and
should be store in ini->rc.
SMC_CLC_DECL_DIFFPREFIX also is not a real error, as for SMC-RV2, it is
not require same prefix.
Guangguan Wang (2):
net/smc: change function name from smc_find_ism_store_rc to
smc_find_device_store_rc
net/smc: correct the reason code in smc_listen_find_device when
fallback
net/smc/af_smc.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
--
2.24.3 (Apple Git-128)
Powered by blists - more mailing lists