linux-kernel - Re: [PATCH V3 4/4] arm64: dts: qcom: ipq5018: Add tsens node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2023 15:13:09 +0200
From:   Robert Marko <robimarko@...il.com>
To:     Sricharan Ramabadhran <quic_srichara@...cinc.com>
Cc:     Sricharan R <srichara@...-platform-upstream01.qualcomm.com>,
        krzysztof.kozlowski@...aro.org, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org,
        srinivas.kandagatla@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        thara.gopinath@...il.com, rafael@...nel.org,
        daniel.lezcano@...aro.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, dmitry.baryshkov@...aro.org
Subject: Re: [PATCH V3 4/4] arm64: dts: qcom: ipq5018: Add tsens node

On Tue, 17 Oct 2023 at 15:07, Sricharan Ramabadhran
<quic_srichara@...cinc.com> wrote:
>
>
>
> On 10/5/2023 12:38 AM, Robert Marko wrote:
> >
> > On 22. 09. 2023. 13:51, Sricharan R wrote:
> >> From: Sricharan Ramabadhran <quic_srichara@...cinc.com>
> >>
> >> IPQ5018 has tsens V1.0 IP with 4 sensors.
> >> There is no RPM, so tsens has to be manually enabled. Adding the tsens
> >> and nvmem node and IPQ5018 has 4 thermal sensors (zones). With the
> >> critical temperature being 120'C and action is to reboot. Adding all
> >> the 4 zones here.
> >>
> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@...cinc.com>
> >> ---
> >>   [v3] Ordered the qfprom device node properties as per
> >>        Krzysztof's comments
> >>
> >>   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 169 ++++++++++++++++++++++++++
> >>   1 file changed, 169 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> >> b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> >> index 9f13d2dcdfd5..9e28b54ebcbd 100644
> >> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> >> @@ -93,6 +93,117 @@ soc: soc@0 {
> >>           #size-cells = <1>;
> >>           ranges = <0 0 0 0xffffffff>;
> >> +        qfprom: qfprom@...00 {
> >> +            compatible = "qcom,ipq5018-qfprom", "qcom,qfprom";
> > Hi,
> >
> > "qcom,ipq5018-qfprom" needs to be documented in QFPROM bindings first.
>
>   Already posted here [1]. Initially had it in the same series, but kept
>   it separately based on review comments.
>
>   [1] https://www.spinics.net/lists/devicetree/msg633408.html

Well, if it's not part of the same series then this addition would
cause a warning as its
undocumented.

I also dont see where is it documented as part of the v2 series.

Regards,
Robert
>
> Regards,
>   Sricharan