linux-kernel - [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Oct 2023 18:49:44 +0530
From:   Krishna Kurapati <quic_kriskura@...cinc.com>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>
CC:     <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <quic_ppratap@...cinc.com>,
        <quic_jackp@...cinc.com>,
        Krishna Kurapati <quic_kriskura@...cinc.com>
Subject: [RFC 4/8] clk: qcom: gcc-sm8450: Keep usb30 prim gdsc on during runtime suspend

When runtime suspend happens in host mode, if cable is removed at this
instant, it triggers a resume where a xhci register access is done when
gdsc is not on leading to a crash. Keep usb30 prim gdsc as on during
runtime suspend to avoid this crash.

Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
---
Note: I am not sure if this is the right way or setting GDSC flags to
PWRSTS_RET_ON is the right approach. So for now made this change to
keep GDSC during host mode runtime suspend.

 drivers/clk/qcom/gcc-sm8450.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c
index 75635d40a12d..47cde2de93a2 100644
--- a/drivers/clk/qcom/gcc-sm8450.c
+++ b/drivers/clk/qcom/gcc-sm8450.c
@@ -2996,6 +2996,7 @@ static struct gdsc usb30_prim_gdsc = {
 	.gdscr = 0x49004,
 	.pd = {
 		.name = "usb30_prim_gdsc",
+		.flags = GENPD_FLAG_RPM_ALWAYS_ON,
 	},
 	.pwrsts = PWRSTS_OFF_ON,
 };
-- 
2.42.0