linux-kernel - RE: [PATCH] iio: resolver: ad2s1210: add reset gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN7PR03MB7132A5B955A660700220ADA78ED6A@SN7PR03MB7132.namprd03.prod.outlook.com>
Date:   Tue, 17 Oct 2023 13:46:51 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     David Lechner <dlechner@...libre.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     David Lechner <dlechner@...libre.com>,
        Jonathan Cameron <jic23@...nel.org>,
        "Sa, Nuno" <Nuno.Sa@...log.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iio: resolver: ad2s1210: add reset gpio support



> -----Original Message-----
> From: David Lechner <dlechner@...libre.com>
> Sent: Montag, 16. Oktober 2023 17:43
> To: linux-iio@...r.kernel.org
> Cc: David Lechner <dlechner@...libre.com>; Jonathan Cameron
> <jic23@...nel.org>; Hennerich, Michael <Michael.Hennerich@...log.com>;
> Sa, Nuno <Nuno.Sa@...log.com>; linux-kernel@...r.kernel.org
> Subject: [PATCH] iio: resolver: ad2s1210: add reset gpio support
> 
> 
> This adds support for the optional reset gpio to the ad2s1210 resolver driver. If
> the gpio is present in the device tree, it is toggled during driver probe before the
> reset of the device initialization. As per the devicetree bindings, it is expected for
> the gpio to configured as active low.
> 
> Suggested-by: Michael Hennerich <Michael.Hennerich@...log.com>
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---

Acked-by: Michael Hennerich <michael.hennerich@...log.com>

>  drivers/iio/resolver/ad2s1210.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c
> index 8646389ec88d..a414eef12e5e 100644
> --- a/drivers/iio/resolver/ad2s1210.c
> +++ b/drivers/iio/resolver/ad2s1210.c
> @@ -1426,6 +1426,7 @@ static int ad2s1210_setup_gpios(struct
> ad2s1210_state *st)  {
>  	struct device *dev = &st->sdev->dev;
>  	struct gpio_descs *resolution_gpios;
> +	struct gpio_desc *reset_gpio;
>  	DECLARE_BITMAP(bitmap, 2);
>  	int ret;
> 
> @@ -1481,6 +1482,17 @@ static int ad2s1210_setup_gpios(struct
> ad2s1210_state *st)
>  					     "failed to set resolution gpios\n");
>  	}
> 
> +	/* If the optional reset GPIO is present, toggle it to do a hard reset. */
> +	reset_gpio = devm_gpiod_get_optional(dev, "reset",
> GPIOD_OUT_HIGH);
> +	if (IS_ERR(reset_gpio))
> +		return dev_err_probe(dev, PTR_ERR(reset_gpio),
> +				     "failed to request reset GPIO\n");
> +
> +	if (reset_gpio) {
> +		udelay(10);
> +		gpiod_set_value(reset_gpio, 0);
> +	}
> +
>  	return 0;
>  }
> 
> --
> 2.42.0