| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231017-womb-lantern-186f16ce67af@spud>
Date: Tue, 17 Oct 2023 14:59:58 +0100
From: Conor Dooley <conor@...nel.org>
To: Tylor Yang <tylor_yang@...ax.corp-partner.google.com>
Cc: dmitry.torokhov@...il.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
jikos@...nel.org, benjamin.tissoires@...hat.com,
linux-input@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org,
poyuan_chang@...ax.corp-partner.google.com,
jingyliang@...omium.org, hbarnor@...omium.org, wuxy23@...ovo.com,
luolm1@...ovo.com, poyu_hung@...ax.corp-partner.google.com
Subject: Re: [PATCH v3 1/4] dt-bindings: input: Introduce Himax HID-over-SPI
device
Yo,
On Tue, Oct 17, 2023 at 05:18:57PM +0800, Tylor Yang wrote:
> The Himax HID-over-SPI framework support for Himax touchscreen ICs
> that report HID packet through SPI bus. The driver core need reset
> pin to meet reset timing spec. of IC. An interrupt to disable
> and enable interrupt when suspend/resume. Two optional power control
> if target board needed.
>
> Signed-off-by: Tylor Yang <tylor_yang@...ax.corp-partner.google.com>
> ---
> .../devicetree/bindings/input/himax,hid.yaml | 123 ++++++++++++++++++
> MAINTAINERS | 6 +
> 2 files changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/himax,hid.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/himax,hid.yaml b/Documentation/devicetree/bindings/input/himax,hid.yaml
> new file mode 100644
> index 000000000000..9ba86fe1b7da
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/himax,hid.yaml
> @@ -0,0 +1,123 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/himax,hid.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Himax TDDI devices using SPI to send HID packets
> +
> +maintainers:
> + - Tylor Yang <tylor_yang@...ax.corp-partner.google.com>
> +
> +description: |
> + Support the Himax TDDI devices which using SPI interface to acquire
> + HID packets from the device. The device needs to be initialized using
> + Himax protocol before it start sending HID packets.
> +
> +properties:
> + compatible:
> + const: himax,hid
This compatible seems far too generic. Why are there not device specific
compatibles for each TDDI device?
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + reset:
> + maxItems: 1
> + description: Reset device, active low signal.
> +
> + vccd-supply:
> + description:
> + Optional regulator for the 1.8V voltage.
> +
> + vcca-supply:
> + description:
> + Optional regulator for the analog 3.3V voltage.
> +
> + himax,id-gpios:
> + maxItems: 8
> + description: GPIOs to read physical Panel ID. Optional.
> +
> + spi-cpha: true
> + spi-cpol: true
> + himax,ic-det-delay-ms:
> + description:
> + Due to TDDI properties, the TPIC detection timing must after the
> + display panel initialized. This property is used to specify the
> + delay time when TPIC detection and display panel initialization
> + timing are overlapped. How much milliseconds to delay before TPIC
> + detection start.
> +
> + himax,ic-resume-delay-ms:
> + description:
> + Due to TDDI properties, the TPIC resume timing must after the
> + display panel resumed. This property is used to specify the
> + delay time when TPIC resume and display panel resume
> + timing are overlapped. How much milliseconds to delay before TPIC
> + resume start.
> + panel:
> + description:
> + The node of the display panel device. The driver will use this
> + node to get the project ID of the display panel. Optional.
> + type: object
> + additionalProperties: false
> +
> + properties:
> + himax,pid:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 8
> + items:
> + minimum: 0
> + maximum: 65535
> + description:
> + When only one value exist, represent Project ID of the device.
> + When multiple values exist, order in event number value represnet
> + id value from id-gpios and odd number value represent Project ID
> + relatives to prior id value. This is used to specify the firmware
> + for the device.
I am sorry, but I still fail to understand why using device specific
compatibles & firmware-name does not work here. It still seems like this
property exists purely because you do not know what device you are
because of a lack of specific compatibles.
Thanks,
Conor.
> +
> + required:
> + - himax,pid
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - reset
> +
> +unevaluatedProperties: false
> +
> +allOf:
> + - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/gpio/gpio.h>
> +
> + spi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + touchscreen@0 {
> + compatible = "himax,hid";
> + reg = <0x0>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <7 IRQ_TYPE_LEVEL_LOW>;
> + pinctrl-0 = <&touch_pins>;
> + pinctrl-names = "default";
> +
> + spi-max-frequency = <12500000>;
> + spi-cpha;
> + spi-cpol;
> +
> + reset = <&gpio1 8 GPIO_ACTIVE_LOW>;
> + himax,ic-det-delay-ms = <500>;
> + himax,ic-resume-delay-ms = <100>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7a7bd8bd80e9..883870ab316f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9340,6 +9340,12 @@ L: linux-kernel@...r.kernel.org
> S: Maintained
> F: drivers/misc/hisi_hikey_usb.c
>
> +HIMAX HID OVER SPI TOUCHSCREEN SUPPORT
> +M: Tylor Yang <tylor_yang@...ax.corp-partner.google.com>
> +L: linux-input@...r.kernel.org
> +S: Supported
> +F: Documentation/devicetree/bindings/input/himax,hid.yaml
> +
> HIMAX HX83112B TOUCHSCREEN SUPPORT
> M: Job Noorman <job@...rman.info>
> L: linux-input@...r.kernel.org
> --
> 2.25.1
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists