[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20231017142313.GC3156@ubuntu>
Date: Tue, 17 Oct 2023 07:23:13 -0700
From: Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Manish Chopra <manishc@...vell.com>, GR-Linux-NIC-Dev@...vell.com,
Coiby Xu <coiby.xu@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
netdev@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org, kumaran.4353@...il.com
Subject: Re: [PATCH] staging: qlge: Replace the occurrences of (1<<x) by
BIT(x)
On Tue, Oct 17, 2023 at 11:18:14AM +0200, Simon Horman wrote:
> On Sun, Oct 15, 2023 at 06:35:58AM -0700, Nandha Kumar Singaram wrote:
> > Adhere to linux coding style. Reported by checkpatch.pl:
> > CHECK: Prefer using the BIT macro
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@...il.com>
>
> Hi Nandha,
>
> I am assuming that checkpatch clean ups are acceptable, perhaps
> even desired, in staging. So this patch seems appropriate to me.
>
> I do, however, see a lot more potential uses of BIT() in qlge.h.
> Could you take a second look?
>
> ...
Hi Simon,
I will look into it and update the patch
Thanks,
Nandha Kumar Singaram
Powered by blists - more mailing lists