linux-kernel - Re: [PATCH 4/6] i3c: master: svc: fix check wrong status register in irq handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231017162846.188d7a78@xps-13>
Date:   Tue, 17 Oct 2023 16:28:46 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Frank Li <Frank.Li@....com>
Cc:     conor.culhane@...vaco.com, alexandre.belloni@...tlin.com,
        joe@...ches.com, linux-i3c@...ts.infradead.org,
        linux-kernel@...r.kernel.org, imx@...ts.linux.dev
Subject: Re: [PATCH 4/6] i3c: master: svc: fix check wrong status register
 in irq handler

Hi Frank,

Frank.Li@....com wrote on Mon, 16 Oct 2023 11:32:30 -0400:

> svc_i3c_master_irq_handler() wrong check register SVC_I3C_MINTMASKED. It

				wrongly checks
> should be SVC_I3C_MSTATUS.

Ah right, good catch.

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

> 
> Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
> Cc: stable@...r.kernel.org
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  drivers/i3c/master/svc-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
> index c252446b2bc5..5ab68d6e439d 100644
> --- a/drivers/i3c/master/svc-i3c-master.c
> +++ b/drivers/i3c/master/svc-i3c-master.c
> @@ -475,7 +475,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
>  static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)
>  {
>  	struct svc_i3c_master *master = (struct svc_i3c_master *)dev_id;
> -	u32 active = readl(master->regs + SVC_I3C_MINTMASKED);
> +	u32 active = readl(master->regs + SVC_I3C_MSTATUS);
>  
>  	if (!SVC_I3C_MSTATUS_SLVSTART(active))
>  		return IRQ_NONE;


Thanks,
Miquèl