linux-kernel - Re: [PATCH 4/6] arm64: dts: qcom: starqltechn: enable more features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <beb42f6d-3c3b-47ea-897b-2a0656ab5c0a@kernel.org>
Date:   Wed, 18 Oct 2023 16:23:33 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Dzmitry Sankouski <dsankouski@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: starqltechn: enable more features

On 18/10/2023 14:30, Dzmitry Sankouski wrote:
> - enable usb 2.0
> - enable debug uart (uart9)
> - enable touchscreen
> - enable ipa so that we can bring up mobile data
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>


>  &usb_1_dwc3 {
>  	/* Until we have Type C hooked up we'll force this as peripheral. */
>  	dr_mode = "peripheral";
> +
> +	maximum-speed = "high-speed";
>  };
>  
>  &usb_1_hsphy {
> @@ -444,4 +580,53 @@ sd_card_det_n_state: sd-card-det-n-state {
>  		function = "gpio";
>  		bias-pull-up;
>  	};
> +
> +	s2dos05_irq: s2dos05_irq {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof