linux-kernel - Re: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative calls to alternative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91bc1200-a12b-4a71-b7d3-f1af94da90d3@suse.com>
Date:   Wed, 18 Oct 2023 17:02:27 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, x86@...nel.org,
        virtualization@...ts.linux-foundation.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ajay Kaher <akaher@...are.com>,
        Alexey Makhalov <amakhalov@...are.com>,
        VMware PV-Drivers Reviewers <pv-drivers@...are.com>
Subject: Re: [PATCH v2 3/4] x86/paravirt: switch mixed paravirt/alternative
 calls to alternative_2

On 18.10.23 13:34, Ingo Molnar wrote:
> 
> * Juergen Gross <jgross@...e.com> wrote:
> 
>> On 16.10.23 16:29, Peter Zijlstra wrote:
>>> On Mon, Oct 16, 2023 at 02:39:32PM +0200, Juergen Gross wrote:
>>>> Instead of stacking alternative and paravirt patching, use the new
>>>> ALT_FLAG_CALL flag to switch those mixed calls to pure alternative
>>>> handling.
>>>>
>>>> This eliminates the need to be careful regarding the sequence of
>>>> alternative and paravirt patching.
>>>>
>>>> For call depth tracking callthunks_setup() needs to be adapted to patch
>>>> calls at alternative patching sites instead of paravirt calls.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@...e.com>
>>>
>>> I cannot help but feel this would've been better as two patches, one
>>> introducing ALT_NOT_XEN and then a second with the rest.
>>
>> In case I need to respin I'll split it up.
> 
> Yeah, would be nice to split this patch into two, as Peter requested.

Okay, will resend the series probably tomorrow.


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature.asc" of type "application/pgp-signature" (496 bytes)