linux-kernel - Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <652f5eddba760_5c0d29449@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Date:   Tue, 17 Oct 2023 21:28:13 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Michal Wilczynski <michal.wilczynski@...el.com>,
        <nvdimm@...ts.linux.dev>, <linux-acpi@...r.kernel.org>,
        <dan.j.williams@...el.com>
CC:     <rafael@...nel.org>, <vishal.l.verma@...el.com>, <lenb@...nel.org>,
        <dave.jiang@...el.com>, <ira.weiny@...el.com>,
        <linux-kernel@...r.kernel.org>,
        Michal Wilczynski <michal.wilczynski@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()

Michal Wilczynski wrote:
> The new cleanup.h facilities that arrived in v6.5-rc1 can replace the
> the usage of devm semantics in acpi_nfit_init_interleave_set(). That
> routine appears to only be using devm to avoid goto statements. The
> new __free() annotation at variable declaration time can achieve the same
> effect more efficiently.
> 
> There is no end user visible side effects of this patch, I was
> motivated to send this cleanup to practice using the new helpers.
> 
> Suggested-by: Dave Jiang <dave.jiang@...el.com>
> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Michal Wilczynski <michal.wilczynski@...el.com>
> ---
> 
> Dan, would you like me to give you credit for the changelog changes
> with Co-developed-by tag ?

Nope, this looks good to me, thanks for fixing it up.

Reviewed-by: Dan Williams <dan.j.williams@...el.com>