linux-kernel - Re: [PATCH 02/10] x86/mm/cpa: Reject incorrect encryption change requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6612974c1101874faedb5c0b5bb6555199ed7321.camel@intel.com>
Date:   Wed, 18 Oct 2023 15:53:14 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "mingo@...nel.org" <mingo@...nel.org>
CC:     "Lutomirski, Andy" <luto@...nel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "Reshetova, Elena" <elena.reshetova@...el.com>,
        "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Cui, Dexuan" <decui@...rosoft.com>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "mikelley@...rosoft.com" <mikelley@...rosoft.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "bp@...en8.de" <bp@...en8.de>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        "sathyanarayanan.kuppuswamy@...ux.intel.com" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH 02/10] x86/mm/cpa: Reject incorrect encryption change
 requests

On Wed, 2023-10-18 at 10:44 +0200, Ingo Molnar wrote:
> > +       /*
> > +        * If any page is already in the right state, bail with an
> > error
> > +        * because the code doesn't handled it. This is likely
> > because
> 
> Grammar mistake here.
> 
> > +        * something has gone wrong and isn't worth optimizing for.
> > +        *
> > +        * If all the memory pages are already in the desired state
> > return
> > +        * success.
> 
> Missing comma.
> 
> > +        *
> > +        * kernel_vaddr_encryped() does not synchronize against
> > huge page
> > +        * splits so take pgd_lock. A caller doing strange things
> > could
> 
> Missing comma.

Oh, yep. Thanks.