[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231018161055.GU1940501@kernel.org>
Date: Wed, 18 Oct 2023 18:10:55 +0200
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Shannon Nelson <shannon.nelson@....com>,
Michael Chan <michael.chan@...adcom.com>,
Cai Huoqing <cai.huoqing@...ux.dev>,
George Cherian <george.cherian@...vell.com>,
Danielle Ratson <danieller@...dia.com>,
Moshe Shemesh <moshe@...dia.com>,
Saeed Mahameed <saeedm@...dia.com>,
Ariel Elior <aelior@...vell.com>,
Manish Chopra <manishc@...vell.com>,
Igor Russkikh <irusskikh@...vell.com>,
Coiby Xu <coiby.xu@...il.com>,
Brett Creeley <brett.creeley@....com>,
Sunil Goutham <sgoutham@...vell.com>,
Linu Cherian <lcherian@...vell.com>,
Geetha sowjanya <gakula@...vell.com>,
Jerin Jacob <jerinj@...vell.com>,
hariprasad <hkelam@...vell.com>,
Subbaraya Sundeep <sbhatta@...vell.com>,
Ido Schimmel <idosch@...dia.com>,
Petr Machata <petrm@...dia.com>,
Eran Ben Elisha <eranbe@...dia.com>,
Aya Levin <ayal@...lanox.com>,
Leon Romanovsky <leon@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 11/11] devlink: convert most of
devlink_fmsg_*() to return void
On Tue, Oct 17, 2023 at 12:53:41PM +0200, Przemek Kitszel wrote:
...
> diff --git a/net/devlink/health.c b/net/devlink/health.c
> index 3858a436598e..f4a6de576b6c 100644
> --- a/net/devlink/health.c
> +++ b/net/devlink/health.c
> @@ -566,17 +566,15 @@ static int devlink_health_do_dump(struct devlink_health_reporter *reporter,
> if (!reporter->dump_fmsg)
> return -ENOMEM;
>
> - err = devlink_fmsg_obj_nest_start(reporter->dump_fmsg);
> - if (err)
> - goto dump_err;
> + devlink_fmsg_obj_nest_start(reporter->dump_fmsg);
>
> err = reporter->ops->dump(reporter, reporter->dump_fmsg,
> priv_ctx, extack);
> if (err)
> goto dump_err;
>
> - err = devlink_fmsg_obj_nest_end(reporter->dump_fmsg);
> - if (err)
> + devlink_fmsg_obj_nest_end(reporter->dump_fmsg);
> + if (reporter->dump_fmsg->err)
Hi Przemek,
Smatch warns that err is not set to an error value here.
> goto dump_err;
>
> reporter->dump_ts = jiffies;
...
Powered by blists - more mailing lists