linux-kernel - Re: [PATCH] pata_lagacy: Handle failed ATA timing computation in opti82c46x_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8332cf70-1451-6903-562f-1d16e4c243ae@omp.ru>
Date:   Wed, 18 Oct 2023 20:15:25 +0300
From:   Sergey Shtylyov <s.shtylyov@....ru>
To:     Haonan Li <lihaonan1105@...il.com>,
        Damien Le Moal <dlemoal@...nel.org>,
        <linux-ide@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pata_lagacy: Handle failed ATA timing computation in
 opti82c46x_set_piomode

Hello!

On 10/18/23 3:52 AM, Haonan Li wrote:

> The function opti82c46x_set_piomode utilizes the ata_timing_compute()
> to determine the appropriate ATA timings for a given device. However,
> in certain conditions where the ata_timing_find_mode() function does
> not find a valid mode, ata_timing_compute() returns an error (-EINVAL),
> leaving the tp struct uninitialized.

   Looks like it's very common to ignore the result of ata_timing_compute()
in drivers/ata/...
   Mind sharing the "certain conditions"? :-) I don't think the set_piomode()
method can be called by libata itself with an unsupported xfer mode...

> This patch checks the return value of ata_timing_compute() and print
> err message. This avoids any potential use of uninitialized `tp`
> struct in the opti82c46x_set_piomode function.
> 
> Signed-off-by: Haonan Li <lihaonan1105@...il.com>
[...]

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

MBR, Sergey