linux-kernel - Re: [PATCH net-next v2 1/5] net: stmmac: simplify debug message on stmmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <vkf6xerp5o7owkvvlbxvd6hkzaj7mml6yutrpaxyowcryh3nlu@qeourmcxk5x3>
Date:   Wed, 18 Oct 2023 13:04:23 -0500
From:   Andrew Halaney <ahalaney@...hat.com>
To:     Johannes Zink <j.zink@...gutronix.de>
Cc:     Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Richard Cochran <richardcochran@...il.com>,
        Kurt Kanzenbach <kurt@...utronix.de>,
        patchwork-jzi@...gutronix.de, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de, vee.khee.wong@...ux.intel.com,
        tee.min.tan@...el.com, rmk+kernel@...linux.org.uk,
        bartosz.golaszewski@...aro.org, horms@...nel.org
Subject: Re: [PATCH net-next v2 1/5] net: stmmac: simplify debug message on
 stmmac_enable()

On Wed, Oct 18, 2023 at 09:09:53AM +0200, Johannes Zink wrote:
> Simplify the netdev_dbg() call in stmmac_enable() in order to reduce code
> duplication. No functional change.
> 
> Signed-off-by: Johannes Zink <j.zink@...gutronix.de>

Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
> 
> ---
> 
> Changelog:
> 
> v1 -> v2: no changes
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> index 1be06b96c35f..f110b91af9bd 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c
> @@ -203,14 +203,10 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
>  			/* Enable External snapshot trigger */
>  			acr_value |= priv->plat->ext_snapshot_num;
>  			acr_value |= PTP_ACR_ATSFC;
> -			netdev_dbg(priv->dev, "Auxiliary Snapshot %d enabled.\n",
> -				   priv->plat->ext_snapshot_num >>
> -				   PTP_ACR_ATSEN_SHIFT);
> -		} else {
> -			netdev_dbg(priv->dev, "Auxiliary Snapshot %d disabled.\n",
> -				   priv->plat->ext_snapshot_num >>
> -				   PTP_ACR_ATSEN_SHIFT);
>  		}
> +		netdev_dbg(priv->dev, "Auxiliary Snapshot %d %s.\n",
> +			   priv->plat->ext_snapshot_num >> PTP_ACR_ATSEN_SHIFT,
> +			   on ? "enabled" : "disabled");
>  		writel(acr_value, ptpaddr + PTP_ACR);
>  		mutex_unlock(&priv->aux_ts_lock);
>  		/* wait for auxts fifo clear to finish */
> 
> -- 
> 2.39.2
>