[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <662a7ca4-beee-4ea3-b77e-4d5af1462f13@linuxfoundation.org>
Date: Wed, 18 Oct 2023 13:08:00 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: zhujun2 <zhujun2@...s.chinamobile.com>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
shuah@...nel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/efivarfs: create-read: fix a resource leak
On 10/17/23 19:59, zhujun2 wrote:
> The opened file should be closed in main(), otherwise resource
> leak will occur that this problem was discovered by code reading
>
> Signed-off-by: zhujun2 <zhujun2@...s.chinamobile.com>
> ---
> tools/testing/selftests/efivarfs/create-read.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
> index 9674a1939..7bc7af4eb 100644
> --- a/tools/testing/selftests/efivarfs/create-read.c
> +++ b/tools/testing/selftests/efivarfs/create-read.c
> @@ -32,8 +32,10 @@ int main(int argc, char **argv)
> rc = read(fd, buf, sizeof(buf));
> if (rc != 0) {
> fprintf(stderr, "Reading a new var should return EOF\n");
> + close(fd);
> return EXIT_FAILURE;
> }
>
> + close(fd);
> return EXIT_SUCCESS;
> }
Thank you. Applied to linux-kselftest next for Linux 6.7-c1.
thanks,
-- Shuah
Powered by blists - more mailing lists