linux-kernel - Re: [PATCH v2 2/2] iio: imu: Add driver for BMI323 IMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231018201309.2cf36489@jic23-huawei>
Date:   Wed, 18 Oct 2023 20:13:09 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Jagath Jog J <jagathjog1996@...il.com>
Cc:     andriy.shevchenko@...ux.intel.com, u.kleine-koenig@...gutronix.de,
        lars@...afoo.de, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, linus.walleij@...aro.org,
        linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] iio: imu: Add driver for BMI323 IMU

On Sun, 15 Oct 2023 16:00:34 +0530
Jagath Jog J <jagathjog1996@...il.com> wrote:

> On Sat, Oct 14, 2023 at 10:16 PM Jonathan Cameron <jic23@...nel.org> wrote:
> >
> > On Fri, 13 Oct 2023 09:18:08 +0530
> > Jagath Jog J <jagathjog1996@...il.com> wrote:
> >  
> > > The Bosch BMI323 is a 6-axis low-power IMU that provide measurements for
> > > acceleration, angular rate, and temperature. This sensor includes
> > > motion-triggered interrupt features, such as a step counter, tap detection,
> > > and activity/inactivity interrupt capabilities.
> > >
> > > The driver supports various functionalities, including data ready, FIFO
> > > data handling, and events such as tap detection, step counting, and
> > > activity interrupts.
> > >
> > > Signed-off-by: Jagath Jog J <jagathjog1996@...il.com>  
> > Hi Jagath,
> >
> > Nice driver.
> >
> > We are rapidly approaching the end of this cycle and as this is a
> > large driver, I think it could do to remain on list at least a week
> > before I apply it or until it picks up some tags from others if that
> > happens sooner. Hence I'm afraid it might well sneak into next cycle.  
> 
> Hi Jonathan
> 
> Thank you for reviewing, I understand the need for additional time
> to ensure a thorough review and to await feedback and tags from
> other reviewers. I'm okay with your schedule.
> 
> > > +
> > > +What:                /sys/.../events/in_accel_gesture_tap_wait_dur
> > > +KernelVersion:       6.7
> > > +Contact:     linux-iio@...r.kernel.org
> > > +Description:
> > > +             Timeout value for tap gesture confirmation.  
> >
> > Units need to be specified.  Seconds?  
> 
> Yes, these are in seconds. I will add units in the next series.
> 
> 
> > >  source "drivers/iio/imu/bmi160/Kconfig"
> > >  source "drivers/iio/imu/bno055/Kconfig"
> > > +source "drivers/iio/imu/bmi323/Kconfig"  
> > Same on ordering.  
> 
> Sure I will correct this in v3.

Given they were so minor I've fixed them up whilst applying.
I doubt this will make 6.7, but you never know if things happen to align.
If not it can have a bit more build test exposure which will do no harm.

Applied to the togreg branch of iio.git and pushed out initially as
testing for all the normal reasons.

Thanks,

Jonathan

> 
> Regards
> Jagath