linux-kernel - Re: [PATCH] tty: serial: samsung

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3360b33c-a6ce-463f-b2d8-43a08340f3c7@linaro.org>
Date:   Wed, 18 Oct 2023 21:52:42 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     André Draszik <git@...red.net>,
        linux-kernel@...r.kernel.org
Cc:     alim.akhtar@...sung.com, gregkh@...uxfoundation.org,
        jirislaby@...nel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
        André Draszik <andre.draszik@...aro.org>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove dead code

On 18/10/2023 12:54, André Draszik wrote:
> From: André Draszik <andre.draszik@...aro.org>
> 
> When support for various old platforms was removed in commit
> 1ea35b355722, s3c24xx_serial_ops also became unused here because

Please use commit xyz ("foo") syntax as pointed out by checkpatch.

> nothing sets port type TYPE_S3C24XX anymore.
> 
> Remove s3c24xx_serial_ops and all the code that's unreachable now.
> 
> Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks")
> Signed-off-by: André Draszik <andre.draszik@...aro.org>

Rest looks good:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof