linux-kernel - Re: [PATCH v2] x86/mm: fix pg_level_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231018203003.GIZTBAS1KUpS7nk8VH@fat_crate.local>
Date:   Wed, 18 Oct 2023 22:30:03 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Ashish Kalra <Ashish.Kalra@....com>
Cc:     dave.hansen@...ux.intel.com, luto@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, x86@...nel.org, hpa@...or.com,
        thomas.lendacky@....com, linux-kernel@...r.kernel.org,
        peterz@...radead.org
Subject: Re: [PATCH v2] x86/mm: fix pg_level_to_pfn for 5-level paging mode.

On Wed, Oct 18, 2023 at 07:06:26PM +0000, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@....com>
> 
> Add support for 5-level paging in pg_level_to_pfn().
> 
> This issue was found during working on SNP guest kexec support,
> this helper function is used during early boot stage for setting
> of C-bit on the PTEs and additionally need this same helper for
> switching shared pages to private during guest kexec.

How to write a proper commit message:

1. Prepare the context for the explanation briefly.

2. Explain the problem at hand.

3. "It happens because of <...>"

4. "Fix it by doing X"

5. "(Potentially do Y)."

For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette