[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87a5sgea0w.fsf@kernel.org>
Date: Wed, 18 Oct 2023 09:10:07 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Felix Fietkau <nbd@....name>,
Lorenzo Bianconi <lorenzo@...nel.org>,
Ryder Lee <ryder.lee@...iatek.com>,
Shayne Chen <shayne.chen@...iatek.com>,
Sean Wang <sean.wang@...iatek.com>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Simon Horman <horms@...nel.org>,
Alexander Couzens <lynxis@...0.eu>,
Nicolas Cavallari <nicolas.cavallari@...en-communications.fr>,
Daniel Golle <daniel@...rotopia.org>,
linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, stable@...r.kernel.org
Subject: Re: [net-next RFC PATCH 1/6] wifi: mt76: fix broken precal loading
from MTD for mt7915
Christian Marangi <ansuelsmth@...il.com> writes:
> Commit 495184ac91bb ("mt76: mt7915: add support for applying
> pre-calibration data") was fundamentally broken and never worked.
>
> The idea (before NVMEM support) was to expand the MTD function and pass
> an additional offset. For normal EEPROM load the offset would always be
> 0. For the purpose of precal loading, an offset was passed that was
> internally the size of EEPROM, since precal data is right after the
> EEPROM.
>
> Problem is that the offset value passed is never handled and is actually
> overwrite by
>
> offset = be32_to_cpup(list);
> ret = mtd_read(mtd, offset, len, &retlen, eep);
>
> resulting in the passed offset value always ingnored. (and even passing
> garbage data as precal as the start of the EEPROM is getting read)
>
> Fix this by adding to the current offset value, the offset from DT to
> correctly read the piece of data at the requested location.
>
> Cc: stable@...r.kernel.org
> Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
> Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
mt76 patches go to Felix's tree, not net-next.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists