linux-kernel - Re: [PATCH] kunit: run test suites only after module initialization completes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202310181220.us7Bvp16-lkp@intel.com>
Date:   Wed, 18 Oct 2023 15:06:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Marco Pagani <marpagan@...hat.com>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Jinjie Ruan <ruanjinjie@...wei.com>
Cc:     oe-kbuild-all@...ts.linux.dev, Marco Pagani <marpagan@...hat.com>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: run test suites only after module initialization
 completes

Hi Marco,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.6-rc6 next-20231017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Marco-Pagani/kunit-run-test-suites-only-after-module-initialization-completes/20231017-161611
base:   linus/master
patch link:    https://lore.kernel.org/r/20231016203548.21993-1-marpagan%40redhat.com
patch subject: [PATCH] kunit: run test suites only after module initialization completes
config: csky-randconfig-002-20231018 (https://download.01.org/0day-ci/archive/20231018/202310181220.us7Bvp16-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310181220.us7Bvp16-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310181220.us7Bvp16-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/csky/include/asm/thread_info.h:9,
                    from include/linux/thread_info.h:60,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/csky/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:79,
                    from include/linux/spinlock.h:56,
                    from include/linux/kref.h:16,
                    from include/kunit/test.h:22,
                    from include/kunit/resource.h:12,
                    from lib/kunit/test.c:9:
   lib/kunit/test.c: In function 'kunit_module_exit':
>> arch/csky/include/asm/page.h:38:43: error: 'high_memory' undeclared (first use in this function)
      38 |                         (void *)(kaddr) < high_memory)
         |                                           ^~~~~~~~~~~
   lib/kunit/test.c:772:34: note: in expansion of macro 'virt_addr_valid'
     772 |         if (!suite_set.start || !virt_addr_valid(suite_set.start))
         |                                  ^~~~~~~~~~~~~~~
   arch/csky/include/asm/page.h:38:43: note: each undeclared identifier is reported only once for each function it appears in
      38 |                         (void *)(kaddr) < high_memory)
         |                                           ^~~~~~~~~~~
   lib/kunit/test.c:772:34: note: in expansion of macro 'virt_addr_valid'
     772 |         if (!suite_set.start || !virt_addr_valid(suite_set.start))
         |                                  ^~~~~~~~~~~~~~~


vim +/high_memory +38 arch/csky/include/asm/page.h

013de2d6671d89 Guo Ren 2018-09-05  36  
013de2d6671d89 Guo Ren 2018-09-05  37  #define virt_addr_valid(kaddr)  ((void *)(kaddr) >= (void *)PAGE_OFFSET && \
013de2d6671d89 Guo Ren 2018-09-05 @38  			(void *)(kaddr) < high_memory)
013de2d6671d89 Guo Ren 2018-09-05  39  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki