linux-kernel - Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d54a96e-17b0-4055-b546-a670d1536af5@linaro.org>
Date:   Wed, 18 Oct 2023 09:14:20 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Elaine Zhang <zhangqing@...k-chips.com>, mturquette@...libre.com,
        sboyd@...nel.org, kever.yang@...k-chips.com, heiko@...ech.de,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-clk@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, huangtao@...k-chips.com,
        andy.yan@...k-chips.com
Subject: Re: [PATCH v4 3/4] dt-bindings: clock: rk3588: export PCLK_VO1GRF clk
 id

On 18/10/2023 09:01, Elaine Zhang wrote:
> MBIST_MCLK_PDM1 is not used,
> Use PCLK_VO1GRF to replace it.
> 
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> ---
>  include/dt-bindings/clock/rockchip,rk3588-cru.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/dt-bindings/clock/rockchip,rk3588-cru.h b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> index 5790b1391201..5816cd71a4e3 100644
> --- a/include/dt-bindings/clock/rockchip,rk3588-cru.h
> +++ b/include/dt-bindings/clock/rockchip,rk3588-cru.h
> @@ -36,7 +36,7 @@
>  #define PCLK_DSU			21
>  #define PCLK_S_DAPLITE			22
>  #define PCLK_M_DAPLITE			23
> -#define MBIST_MCLK_PDM1			24
> +#define PCLK_VO1GRF			24

That's an ABI break without justification.

Best regards,
Krzysztof