linux-kernel - Re: [PATCH] staging: vme_user: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023101841-unglazed-hydration-d6b8@gregkh>
Date:   Wed, 18 Oct 2023 09:40:04 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Calvince Otieno <calvncce@...il.com>
Cc:     gustavo@...eddedor.com, outreachy@...ts.linux.dev,
        Julia Lawall <julia.lawall@...ia.fr>,
        Martyn Welch <martyn@...chs.me.uk>,
        Manohar Vanga <manohar.vanga@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: fix coding style - remove CamelCasing

On Wed, Oct 18, 2023 at 10:22:50AM +0300, Calvince Otieno wrote:
> This patch addresses coding style errors identified by checkpatch. The
> changes include converting camel case names in constant variables to
> UPPERCASE. These changes align with the coding style guidelines.
> 
> 
> Signed-off-by: Calvince Otieno <calvncce@...il.com>
> ---
>  drivers/staging/vme_user/vme.h        | 12 ++--
>  drivers/staging/vme_user/vme_fake.c   |  8 +--
>  drivers/staging/vme_user/vme_tsi148.c | 88 +++++++++++++--------------
>  3 files changed, 54 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme.h b/drivers/staging/vme_user/vme.h
> index fbcbd0204453..0b40859fee23 100644
> --- a/drivers/staging/vme_user/vme.h
> +++ b/drivers/staging/vme_user/vme.h
> @@ -33,13 +33,13 @@ enum vme_resource_type {
>  #define VME_SCT		0x1
>  #define VME_BLT		0x2
>  #define VME_MBLT	0x4
> -#define VME_2eVME	0x8
> -#define VME_2eSST	0x10
> -#define VME_2eSSTB	0x20
> +#define VME_2EVME	0x8
> +#define VME_2ESST	0x10
> +#define VME_2ESSTB	0x20

Checkpatch is wrong here, this should stay as-is.

thanks,

greg k-h