lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <870b9b74-75bc-2a0d-7138-ae8df237f980@intel.com>
Date:   Wed, 18 Oct 2023 10:12:19 +0200
From:   Karolina Stolarek <karolina.stolarek@...el.com>
To:     Dorcas AnonoLitunya <anonolitunya@...il.com>
CC:     <outreachy@...ts.linux.dev>, <julia.lawall@...ia.fr>,
        <dan.carpenter@...aro.org>, <andi.shyti@...ux.intel.com>,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        <linux-fbdev@...r.kernel.org>, <linux-staging@...ts.linux.dev>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Staging: sm750fb: Rename
 display_control_adjust_sm750LE

On 18.10.2023 10:04, Dorcas AnonoLitunya wrote:
> Rename function display_control_adjust_sm750LE to
> display_control_adjust_sm750le. This further enforces snakecase naming
> convention for consistent naming style throughout entire file.
> 
> This change was suggested by Andi Shyti <andi.shyti@...ux.intel.com>

You can use Suggested-by tag here, if you wish (as per [1]) before 
Signed-off-by line.

In the first line of the commit, "Staging" should be lowercase.

All the best,
Karolina

-----
[1] - Documentation/process/submitting-patches.rst

> 
> Signed-off-by: Dorcas AnonoLitunya <anonolitunya@...il.com>
> ---
> 
> v2: Correctly spells Andi Shyti's name
> 
>   drivers/staging/sm750fb/ddk750_mode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index f3f354831617..bcdd291d25c9 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -14,7 +14,7 @@
>    * in bit 29:27 of Display Control register.
>    */
>   static unsigned long
> -display_control_adjust_SM750LE(struct mode_parameter *mode_param,
> +display_control_adjust_sm750le(struct mode_parameter *mode_param,
>   			       unsigned long disp_control)
>   {
>   	unsigned long x, y;
> @@ -125,7 +125,7 @@ static int program_mode_registers(struct mode_parameter *mode_param,
>   			tmp |= DISPLAY_CTRL_HSYNC_PHASE;
>   
>   		if (sm750_get_chip_type() == SM750LE) {
> -			display_control_adjust_SM750LE(mode_param, tmp);
> +			display_control_adjust_sm750le(mode_param, tmp);
>   		} else {
>   			reg = peek32(CRT_DISPLAY_CTRL) &
>   				~(DISPLAY_CTRL_VSYNC_PHASE |

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ