[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c2941f5-9909-433a-a35e-fbe7611c0ef4@linaro.org>
Date: Wed, 18 Oct 2023 10:14:03 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Banajit Goswami <bgoswami@...cinc.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: qcom: q6apm-lpass-dais: pass max number of channels
to Audioreach
On 17/10/2023 18:14, Krzysztof Kozlowski wrote:
> Using the params_channels() helper when setting hw_params, results in
> passing to Audioreach minimum number of channels valid for given
> hardware. This is not valid for any hardware which sets minimum
> channels to two and maximum to something bigger, like four channels.
>
> Instead pass the maximum number of supported channels to allow playback
> of multi-channel formats.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 4 ++--
I am not sure if this is correct fix. I think sound machine drivers
should just not override channels like:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/sound/soc/qcom/sm8250.c?h=v6.6-rc6#n44
Best regards,
Krzysztof
Powered by blists - more mailing lists