linux-kernel - Re: [PATCH v2] Staging: sm750fb: Rename display_control_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d219a6b7-0b59-4894-a0c3-01e286f6a132@kadam.mountain>
Date:   Wed, 18 Oct 2023 12:31:18 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Karolina Stolarek <karolina.stolarek@...el.com>
Cc:     Dorcas AnonoLitunya <anonolitunya@...il.com>,
        outreachy@...ts.linux.dev, julia.lawall@...ia.fr,
        andi.shyti@...ux.intel.com,
        Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-fbdev@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: sm750fb: Rename
 display_control_adjust_sm750LE

On Wed, Oct 18, 2023 at 10:12:19AM +0200, Karolina Stolarek wrote:
> On 18.10.2023 10:04, Dorcas AnonoLitunya wrote:
> > Rename function display_control_adjust_sm750LE to
> > display_control_adjust_sm750le. This further enforces snakecase naming
> > convention for consistent naming style throughout entire file.
> > 
> > This change was suggested by Andi Shyti <andi.shyti@...ux.intel.com>
> 
> You can use Suggested-by tag here, if you wish (as per [1]) before
> Signed-off-by line.

Yeah

> 
> In the first line of the commit, "Staging" should be lowercase.

There isn't really a rule on this.  People do it either way.  But, sure,
in this directory it's a 404 lower case vs 51 upper case so better to
follow the majority opinion.

In outreachy people are way more strict about some process issues than
we would be in real life.  And that's fine, because it's an educational
process.  I just worry that there is a certain amount of bleed over
where people start "correcting" people who haven't signed up to be in
outreachy.

regards,
dan carpenter