[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae494e9e-63da-4644-8653-b29d76021907@xs4all.nl>
Date: Wed, 18 Oct 2023 12:32:14 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Benjamin Gaignard <benjamin.gaignard@...labora.com>,
mchehab@...nel.org, tfiga@...omium.org, m.szyprowski@...sung.com,
ming.qian@....com, ezequiel@...guardiasur.com.ar,
p.zabel@...gutronix.de, gregkh@...uxfoundation.org,
nicolas.dufresne@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
kernel@...labora.com
Subject: Re: [PATCH v12 39/56] media: usb: Stop direct calls to queue
num_buffers field
Subject line doesn't mention 'airspy:'
Regards,
Hans
On 17/10/2023 16:47, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffers field directly.
> This allows us to change how the number of buffers is computed in the
> futur.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> ---
> drivers/media/usb/airspy/airspy.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
> index 462eb8423506..e24e655fb1db 100644
> --- a/drivers/media/usb/airspy/airspy.c
> +++ b/drivers/media/usb/airspy/airspy.c
> @@ -482,12 +482,13 @@ static int airspy_queue_setup(struct vb2_queue *vq,
> unsigned int *nplanes, unsigned int sizes[], struct device *alloc_devs[])
> {
> struct airspy *s = vb2_get_drv_priv(vq);
> + unsigned int q_num_bufs = vb2_get_num_buffers(vq);
>
> dev_dbg(s->dev, "nbuffers=%d\n", *nbuffers);
>
> /* Need at least 8 buffers */
> - if (vq->num_buffers + *nbuffers < 8)
> - *nbuffers = 8 - vq->num_buffers;
> + if (q_num_bufs + *nbuffers < 8)
> + *nbuffers = 8 - q_num_bufs;
> *nplanes = 1;
> sizes[0] = PAGE_ALIGN(s->buffersize);
>
Powered by blists - more mailing lists