linux-kernel - Re: [PATCH v1] driver core: Release all resources during unbind before updating device links

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231018104029.zairwt4nzub33ekr@pengutronix.de>
Date:   Wed, 18 Oct 2023 12:40:29 +0200
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Yang Yingliang <yangyingliang@...wei.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        James Clark <james.clark@....com>, kernel-team@...roid.com,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] driver core: Release all resources during unbind
 before updating device links

On Tue, Oct 17, 2023 at 06:38:50PM -0700, Saravana Kannan wrote:
> This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
> dependencies tracking support") where the device link status was
> incorrectly updated in the driver unbind path before all the device's
> resources were released.
> 
> Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
> Reported-by: "Uwe Kleine-König" <u.kleine-koenig@...gutronix.de>
> Closes: https://lore.kernel.org/all/20231014161721.f4iqyroddkcyoefo@pengutronix.de/
> Signed-off-by: Saravana Kannan <saravanak@...gle.com>
> Cc: Thierry Reding <thierry.reding@...il.com>
> Cc: Yang Yingliang <yangyingliang@...wei.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Matti Vaittinen <mazziesaccount@...il.com>
> Cc: James Clark <james.clark@....com>
> ---
>  drivers/base/dd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index a528cec24264..0c3725c3eefa 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
>  		if (dev->bus && dev->bus->dma_cleanup)
>  			dev->bus->dma_cleanup(dev);
>  
> -		device_links_driver_cleanup(dev);
>  		device_unbind_cleanup(dev);
> +		device_links_driver_cleanup(dev);

Tested-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

This indeed fixes the crash I experinced before.

Thanks a lot!
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)