[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8dfdc8a5-339a-43e8-8d82-0597a6187336@starfivetech.com>
Date: Wed, 18 Oct 2023 18:50:30 +0800
From: Minda Chen <minda.chen@...rfivetech.com>
To: Conor Dooley <conor@...nel.org>
CC: Krzysztof WilczyĆski <kw@...ux.com>,
Rob Herring <robh+dt@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Daire McNamara <daire.mcnamara@...rochip.com>,
"Emil Renner Berthing" <emil.renner.berthing@...onical.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-riscv@...ts.infradead.org>, <linux-pci@...r.kernel.org>,
Paul Walmsley <paul.walmsley@...ive.com>,
"Palmer Dabbelt" <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
"Philipp Zabel" <p.zabel@...gutronix.de>,
Mason Huo <mason.huo@...rfivetech.com>,
Leyfoon Tan <leyfoon.tan@...rfivetech.com>,
Kevin Xie <kevin.xie@...rfivetech.com>
Subject: Re: [PATCH v8 10/22] PCI: plda: Add PLDA default event IRQ handler
On 2023/10/18 18:44, Conor Dooley wrote:
> On Wed, Oct 11, 2023 at 07:05:02PM +0800, Minda Chen wrote:
>> Add PLDA default event IRQ handler.
>> This is first patch of refactoring IRQ handling codes.
>> The handler function will be referenced by later patch.
>>
>> Signed-off-by: Minda Chen <minda.chen@...rfivetech.com>
>> ---
>> drivers/pci/controller/plda/pcie-plda-host.c | 5 +++++
>> drivers/pci/controller/plda/pcie-plda.h | 1 +
>
> Dunno what hte PCI maintainers take is on this kind of thing, but this
> patch adds dead code, as there is no user for it until the follow-on
> patch you mention. Did someone ask you to split this out?
>
> Cheers,
> Conor.
>
No one. Previous this patch contain other codes. I modify this incorrect. I will squash this with other patch. Thanks.
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/controller/plda/pcie-plda-host.c
>> index 19131181897f..21ca6b460f5e 100644
>> --- a/drivers/pci/controller/plda/pcie-plda-host.c
>> +++ b/drivers/pci/controller/plda/pcie-plda-host.c
>> @@ -18,6 +18,11 @@
>>
>> #include "pcie-plda.h"
>>
>> +irqreturn_t plda_event_handler(int irq, void *dev_id)
>> +{
>> + return IRQ_HANDLED;
>> +}
>> +
>> void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
>> phys_addr_t axi_addr, phys_addr_t pci_addr,
>> size_t size)
>> diff --git a/drivers/pci/controller/plda/pcie-plda.h b/drivers/pci/controller/plda/pcie-plda.h
>> index 3deefd35fa5a..7ff7ff44c980 100644
>> --- a/drivers/pci/controller/plda/pcie-plda.h
>> +++ b/drivers/pci/controller/plda/pcie-plda.h
>> @@ -120,6 +120,7 @@ struct plda_pcie_rp {
>> void __iomem *bridge_addr;
>> };
>>
>> +irqreturn_t plda_event_handler(int irq, void *dev_id);
>> void plda_pcie_setup_window(void __iomem *bridge_base_addr, u32 index,
>> phys_addr_t axi_addr, phys_addr_t pci_addr,
>> size_t size);
>> --
>> 2.17.1
>>
Powered by blists - more mailing lists